GroupBy GroupedObservables should not re-subscribe to parent sequence #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReactiveX#282 Refactored to maintain a single subscription that propagates events to the correct child GroupedObservables.
|
RxJava-pull-requests #154 FAILURE |
- support unsubscribing from parent and/or child - The following is now possible: ``` groupBy().take(1).mapMany(group -> group.take(20)) ``` - the subscription on the parent will cause new groups to stop being sent, but it will keep sending events until all previously created groups are unsubscribed from
|
RxJava-pull-requests #155 FAILURE |
|
Replaced with #284 |
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
This is already being avoided in the other registries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#282
Refactored to maintain a single subscription that propagates events to the correct child GroupedObservables.